<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Build fails for X11+EGL due to missing gst_gl_display_x11_new_with_display()"
href="https://bugs.webkit.org/show_bug.cgi?id=162606">162606</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Build fails for X11+EGL due to missing gst_gl_display_x11_new_with_display()
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebCore Misc.
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mario@webkit.org
</td>
</tr>
<tr>
<th>CC</th>
<td>magomez@igalia.com
</td>
</tr></table>
<p>
<div>
<pre>In MediaPlayerPrivateGStreamerBase::ensureGstGLContext() [1] a call to either gst_gl_display_x11_new_with_display() or gst_gl_display_egl_new_with_egl_display() is made depending on whether we're building for X11 or Wayland:
[...]
#if PLATFORM(X11)
m_glDisplay = GST_GL_DISPLAY(gst_gl_display_x11_new_with_display(downcast<PlatformDisplayX11>(sharedDisplay).native()));
#elif PLATFORM(WAYLAND)
m_glDisplay = GST_GL_DISPLAY(gst_gl_display_egl_new_with_egl_display(downcast<PlatformDisplayWayland>(sharedDisplay).native()));
#endif
[...]
However, this will fail when building for X11 with EGL (instead of GLX), since gst_gl_display_x11_new_with_display() is defined in /usr/include/gst/gl/x11/gstgldisplay_x11.h, which doesn't get included for EGL:
[...]
#include "GLContext.h"
#if USE(GLX)
#include "GLContextGLX.h"
#include <gst/gl/x11/gstgldisplay_x11.h>
#elif USE(EGL)
#include "GLContextEGL.h"
#include <gst/gl/egl/gstgldisplay_egl.h>
#endif
[...]
I believe a simple fix is to change the condition there to check for GLX or EGL, instead of X11 or WAYLAND.
[1] <a href="https://svn.webkit.org/repository/webkit/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp">https://svn.webkit.org/repository/webkit/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>