[Webkit-unassigned] [Bug 162594] Extend perf dashboard to support multiple pages.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 26 22:33:34 PDT 2016


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #289916|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 289916
  --> https://bugs.webkit.org/attachment.cgi?id=289916

View in context: https://bugs.webkit.org/attachment.cgi?id=289916&action=review

> Websites/perf.webkit.org/public/v3/main.js:60
>          else if (dashboardPages)

There is a bug here. We should be checking dashboardPages.length here as well.

> Websites/perf.webkit.org/public/v3/pages/summary-page.js:30
> -    routeName() { return 'summary'; }
> +    routeName() { return this._route; }

We should use `summary/${this._name}` instead just like we do in DashboardPage.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160927/0f61eaae/attachment.html>

More information about the webkit-unassigned mailing list