<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend perf dashboard to support multiple pages."
href="https://bugs.webkit.org/show_bug.cgi?id=162594">bug 162594</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #289916 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend perf dashboard to support multiple pages."
href="https://bugs.webkit.org/show_bug.cgi?id=162594#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Extend perf dashboard to support multiple pages."
href="https://bugs.webkit.org/show_bug.cgi?id=162594">bug 162594</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289916&action=diff" name="attach_289916" title="Patch">attachment 289916</a> <a href="attachment.cgi?id=289916&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289916&action=review">https://bugs.webkit.org/attachment.cgi?id=289916&action=review</a>
<span class="quote">> Websites/perf.webkit.org/public/v3/main.js:60
> else if (dashboardPages)</span >
There is a bug here. We should be checking dashboardPages.length here as well.
<span class="quote">> Websites/perf.webkit.org/public/v3/pages/summary-page.js:30
> - routeName() { return 'summary'; }
> + routeName() { return this._route; }</span >
We should use `summary/${this._name}` instead just like we do in DashboardPage.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>