[Webkit-unassigned] [Bug 162564] [GTK] Mac defaults are used for key shortcuts on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162564

--- Comment #6 from Tomas Popela <tpopela at redhat.com> ---
(In reply to comment #5)
> Comment on attachment 289833 [details]
> Fix style issue
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=289833&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js:575
> > +    var mac = CodeMirror.keyMap["default"] == CodeMirror.keyMap.macDefault;
> 
> Style: strict equality (===) is used almost exclusively throughout the
> codebase. Also we've been preferring `let` over `var` for new code.

Thanks, I will update the patch. I copy the code from CodeMirror, but I will use the detection that is used across the Inspector code:

let mac = WebInspector.Platform.name === "mac";

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160926/c9b97ba5/attachment.html>