<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Mac defaults are used for key shortcuts on Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=162564#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Mac defaults are used for key shortcuts on Linux"
href="https://bugs.webkit.org/show_bug.cgi?id=162564">bug 162564</a>
from <span class="vcard"><a class="email" href="mailto:tpopela@redhat.com" title="Tomas Popela <tpopela@redhat.com>"> <span class="fn">Tomas Popela</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=162564#c5">comment #5</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=289833&action=diff" name="attach_289833" title="Fix style issue">attachment 289833</a> <a href="attachment.cgi?id=289833&action=edit" title="Fix style issue">[details]</a></span>
> Fix style issue
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=289833&action=review">https://bugs.webkit.org/attachment.cgi?id=289833&action=review</a>
>
> > Source/WebInspectorUI/UserInterface/Views/CodeMirrorAdditions.js:575
> > + var mac = CodeMirror.keyMap["default"] == CodeMirror.keyMap.macDefault;
>
> Style: strict equality (===) is used almost exclusively throughout the
> codebase. Also we've been preferring `let` over `var` for new code.</span >
Thanks, I will update the patch. I copy the code from CodeMirror, but I will use the detection that is used across the Inspector code:
let mac = WebInspector.Platform.name === "mac";</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>