[Webkit-unassigned] [Bug 162530] [JSC] ES6 Method functions should not have prototype

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162530

--- Comment #22 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
(In reply to comment #20)
> (In reply to comment #19)
> > Comment on attachment 289761 [details]
> > Fix LayoutTests
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=289761&action=review
> > 
> > >> Source/JavaScriptCore/runtime/JSFunction.cpp:356
> > >> +    bool isMethod = executable->isMethod() && !executable->isClass();
> > > 
> > > Why the  "!isClass" here?
> > > We distinguish between methods on object literals and methods on classes?
> > > 
> > > What's the behavior for object literals? Please add tests for that.
> > 
> > 'isClass' really means "class constructor", which is a special case (gets a
> > prototype property during MakeConstructor
> > (https://tc39.github.io/ecma262/#sec-makeconstructor) during step 16 of
> > ClassDefinitionEvaluation
> > (https://tc39.github.io/ecma262/#sec-runtime-semantics-
> > classdefinitionevaluation).
> Oh wow. Let's please rename that method. That's horribly misleading.
> 
> > 
> > I'll add some extra tests either tomorrow or during the week)
> Cool, thanks.

Got it done while waiting in the airport instead, I guess :) I'm not positive the tests will pass (laptop is a bit low powered to check this at the moment), but if it doesn't, will obviously fix it up tomorrow or monday.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160925/4aab5e75/attachment-0001.html>