<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] ES6 Method functions should not have prototype"
href="https://bugs.webkit.org/show_bug.cgi?id=162530#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] ES6 Method functions should not have prototype"
href="https://bugs.webkit.org/show_bug.cgi?id=162530">bug 162530</a>
from <span class="vcard"><a class="email" href="mailto:caitp@igalia.com" title="Caitlin Potter (:caitp) <caitp@igalia.com>"> <span class="fn">Caitlin Potter (:caitp)</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=162530#c20">comment #20</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=162530#c19">comment #19</a>)
> > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=289761&action=diff" name="attach_289761" title="Fix LayoutTests">attachment 289761</a> <a href="attachment.cgi?id=289761&action=edit" title="Fix LayoutTests">[details]</a></span>
> > Fix LayoutTests
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=289761&action=review">https://bugs.webkit.org/attachment.cgi?id=289761&action=review</a>
> >
> > >> Source/JavaScriptCore/runtime/JSFunction.cpp:356
> > >> + bool isMethod = executable->isMethod() && !executable->isClass();
> > >
> > > Why the "!isClass" here?
> > > We distinguish between methods on object literals and methods on classes?
> > >
> > > What's the behavior for object literals? Please add tests for that.
> >
> > 'isClass' really means "class constructor", which is a special case (gets a
> > prototype property during MakeConstructor
> > (<a href="https://tc39.github.io/ecma262/#sec-makeconstructor">https://tc39.github.io/ecma262/#sec-makeconstructor</a>) during step 16 of
> > ClassDefinitionEvaluation
> > (<a href="https://tc39.github.io/ecma262/#sec-runtime-semantics">https://tc39.github.io/ecma262/#sec-runtime-semantics</a>-
> > classdefinitionevaluation).
> Oh wow. Let's please rename that method. That's horribly misleading.
>
> >
> > I'll add some extra tests either tomorrow or during the week)
> Cool, thanks.</span >
Got it done while waiting in the airport instead, I guess :) I'm not positive the tests will pass (laptop is a bit low powered to check this at the moment), but if it doesn't, will obviously fix it up tomorrow or monday.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>