[Webkit-unassigned] [Bug 162532] AuthorStyleSheets shouldn't trigger synchronous style resolutions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162532

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289748|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 289748
  --> https://bugs.webkit.org/attachment.cgi?id=289748
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289748&action=review

> Source/WebCore/dom/AuthorStyleSheets.h:66
> +    enum class ChangeType { ActiveSet, ContentsOrInterpretation };
> +    WEBCORE_EXPORT void didChange(ChangeType);

Does this really need to be a single function call with an argument? It’s kind of wordy to call it that way. Maybe we should make this two different named functions. They can share code inside the class and we can use the ChangeType f we find it handy internally, but I suspect there is no real advantage to callers that this is an argument rather than a separate function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160925/92760975/attachment-0001.html>