<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - AuthorStyleSheets shouldn't trigger synchronous style resolutions"
href="https://bugs.webkit.org/show_bug.cgi?id=162532">bug 162532</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #289748 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AuthorStyleSheets shouldn't trigger synchronous style resolutions"
href="https://bugs.webkit.org/show_bug.cgi?id=162532#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AuthorStyleSheets shouldn't trigger synchronous style resolutions"
href="https://bugs.webkit.org/show_bug.cgi?id=162532">bug 162532</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289748&action=diff" name="attach_289748" title="patch">attachment 289748</a> <a href="attachment.cgi?id=289748&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289748&action=review">https://bugs.webkit.org/attachment.cgi?id=289748&action=review</a>
<span class="quote">> Source/WebCore/dom/AuthorStyleSheets.h:66
> + enum class ChangeType { ActiveSet, ContentsOrInterpretation };
> + WEBCORE_EXPORT void didChange(ChangeType);</span >
Does this really need to be a single function call with an argument? It’s kind of wordy to call it that way. Maybe we should make this two different named functions. They can share code inside the class and we can use the ChangeType f we find it handy internally, but I suspect there is no real advantage to callers that this is an argument rather than a separate function.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>