[Webkit-unassigned] [Bug 159398] [test262] Fixing mapped arguments object property test case

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159398

--- Comment #42 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 284985
  --> https://bugs.webkit.org/attachment.cgi?id=284985
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284985&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        property cases. Also it is fixing cases where arguments[i]
> +        cannot be deleted when argument "i" is not configurable.

Shouldn't being non-configurable mean you can't be deleted?

> Source/JavaScriptCore/ChangeLog:14
> +        aliased xor stored in a JSObject with attributes. This patch changes

what does it mean to be aliased in this situation?

> Source/JavaScriptCore/ChangeLog:18
> +        attribute is true. It is important realize that when the attribute is

Really? I thought it can't be deleted if configurable is false. That's how normal objects work, anyways.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:145
> +    PropertySlot slot(thisObject, PropertySlot::InternalMethodType::GetOwnProperty);

Seems like this should be ::VMInquiry. ::GetOwnProperty is allowed to do arbitrary side effects.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:179
> +    PropertySlot slot(thisObject, PropertySlot::InternalMethodType::GetOwnProperty);

Ditto.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:228
> +                if (descriptor.writable() && descriptor.configurable())

Please change the above comment to reflect the new behavior.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:238
> +            if ((descriptor.writablePresent() && !descriptor.writable()) || descriptor.isAccessorDescriptor())

Why do we care about it being non-writable? I thought for deleting a property, we care about it being configurable?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160924/e604fa7d/attachment.html>