<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [test262] Fixing mapped arguments object property test case"
href="https://bugs.webkit.org/show_bug.cgi?id=159398#c42">Comment # 42</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [test262] Fixing mapped arguments object property test case"
href="https://bugs.webkit.org/show_bug.cgi?id=159398">bug 159398</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284985&action=diff" name="attach_284985" title="Patch">attachment 284985</a> <a href="attachment.cgi?id=284985&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284985&action=review">https://bugs.webkit.org/attachment.cgi?id=284985&action=review</a>
<span class="quote">> Source/JavaScriptCore/ChangeLog:11
> + property cases. Also it is fixing cases where arguments[i]
> + cannot be deleted when argument "i" is not configurable.</span >
Shouldn't being non-configurable mean you can't be deleted?
<span class="quote">> Source/JavaScriptCore/ChangeLog:14
> + aliased xor stored in a JSObject with attributes. This patch changes</span >
what does it mean to be aliased in this situation?
<span class="quote">> Source/JavaScriptCore/ChangeLog:18
> + attribute is true. It is important realize that when the attribute is</span >
Really? I thought it can't be deleted if configurable is false. That's how normal objects work, anyways.
<span class="quote">> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:145
> + PropertySlot slot(thisObject, PropertySlot::InternalMethodType::GetOwnProperty);</span >
Seems like this should be ::VMInquiry. ::GetOwnProperty is allowed to do arbitrary side effects.
<span class="quote">> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:179
> + PropertySlot slot(thisObject, PropertySlot::InternalMethodType::GetOwnProperty);</span >
Ditto.
<span class="quote">> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:228
> + if (descriptor.writable() && descriptor.configurable())</span >
Please change the above comment to reflect the new behavior.
<span class="quote">> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:238
> + if ((descriptor.writablePresent() && !descriptor.writable()) || descriptor.isAccessorDescriptor())</span >
Why do we care about it being non-writable? I thought for deleting a property, we care about it being configurable?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>