[Webkit-unassigned] [Bug 162367] Add long press selection test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162367

--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 289609
  --> https://bugs.webkit.org/attachment.cgi?id=289609
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289609&action=review

> Tools/ChangeLog:14
> +        Fixed incorrectly typed constats. NSTimeInterval is in seconds, origial numbers were nanoseconds and typedefed to long without reguard to the type differences.

Lots of typos in this line (constants, reguard), but I think it's also just not factual anymore, right?

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:549
> +    void (^completionBlockCopy)() = Block_copy(completionBlock);

Wonder if this should be using BlockPtr :D

> LayoutTests/fast/events/touch/ios/long-press-to-select-text.html:59
> +	PressMe<p>

I think smfr probably meant

<p>PressMe</p>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160922/e42a539b/attachment.html>