<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add long press selection test"
href="https://bugs.webkit.org/show_bug.cgi?id=162367#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add long press selection test"
href="https://bugs.webkit.org/show_bug.cgi?id=162367">bug 162367</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289609&action=diff" name="attach_289609" title="Patch">attachment 289609</a> <a href="attachment.cgi?id=289609&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289609&action=review">https://bugs.webkit.org/attachment.cgi?id=289609&action=review</a>
<span class="quote">> Tools/ChangeLog:14
> + Fixed incorrectly typed constats. NSTimeInterval is in seconds, origial numbers were nanoseconds and typedefed to long without reguard to the type differences.</span >
Lots of typos in this line (constants, reguard), but I think it's also just not factual anymore, right?
<span class="quote">> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:549
> + void (^completionBlockCopy)() = Block_copy(completionBlock);</span >
Wonder if this should be using BlockPtr :D
<span class="quote">> LayoutTests/fast/events/touch/ios/long-press-to-select-text.html:59
> + PressMe<p></span >
I think smfr probably meant
<p>PressMe</p></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>