[Webkit-unassigned] [Bug 161409] [JSC] Implement parsing of Async Functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161409

--- Comment #47 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 289447
  --> https://bugs.webkit.org/attachment.cgi?id=289447
Async Function Parsing v6 + Copy-edit the build-jsc help message changes

View in context: https://bugs.webkit.org/attachment.cgi?id=289447&action=review

>>>> Tools/Scripts/build-jsc:211
>>>> +            if ($featureEnabled != $_->{default}) {
>>> 
>>> For string, we need to use ne instead of !=. This causes warnings.
>> 
>> Not just warnings, incorrect behavior! Using != causes it to do a numeric comparison, not a string one. For example, ("ON" != "OFF") is false because both strings have a numeric value of 0.
> 
> Done --- Right, this was sloppily written entirely and has been fixed up. Note, the behaviour is different from build-webkit, but I don't think it should really matter. Thanks for the look and testing on cmake.

Oops, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160921/ab410ff2/attachment-0001.html>