<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement parsing of Async Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=161409#c47">Comment # 47</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement parsing of Async Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=161409">bug 161409</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=289447&action=diff" name="attach_289447" title="Async Function Parsing v6 + Copy-edit the build-jsc help message changes">attachment 289447</a> <a href="attachment.cgi?id=289447&action=edit" title="Async Function Parsing v6 + Copy-edit the build-jsc help message changes">[details]</a></span>
Async Function Parsing v6 + Copy-edit the build-jsc help message changes
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289447&action=review">https://bugs.webkit.org/attachment.cgi?id=289447&action=review</a>
<span class="quote">>>>> Tools/Scripts/build-jsc:211
>>>> + if ($featureEnabled != $_->{default}) {
>>>
>>> For string, we need to use ne instead of !=. This causes warnings.
>>
>> Not just warnings, incorrect behavior! Using != causes it to do a numeric comparison, not a string one. For example, ("ON" != "OFF") is false because both strings have a numeric value of 0.
>
> Done --- Right, this was sloppily written entirely and has been fixed up. Note, the behaviour is different from build-webkit, but I don't think it should really matter. Thanks for the look and testing on cmake.</span >
Oops, thanks!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>