[Webkit-unassigned] [Bug 161409] [JSC] Implement parsing of Async Functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161409

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289447|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #41 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 289447
  --> https://bugs.webkit.org/attachment.cgi?id=289447
Async Function Parsing v6 + Copy-edit the build-jsc help message changes

View in context: https://bugs.webkit.org/attachment.cgi?id=289447&action=review

r=me, with nits.

> Source/JavaScriptCore/ChangeLog:87
> +        * runtime/CommonIdentifiers.h:

Could you update this ChangeLog by using Tools/Scripts/webkit-patch upload --update-changelogs?

> Source/JavaScriptCore/parser/Parser.h:1560
> +        // FIXME: `m_moduleScopeData.get() != nullptr` is not a valid method of determining if parser is parsing a Module.

Could you open a bug for this and note the URL here?
And I think this can be easily fixed since we already have this information: JSParserCommentMode {Classic, Module}!
This flag is named like this since currently it is only used for controlling comment mode. When you use this information here, you need to rename this mode to something different one (maybe, JSParserScriptMode?).

> Source/JavaScriptCore/parser/Parser.h:1568
> +        // FIXME: `m_moduleScopeData.get() != nullptr` is not a valid method of determining if parser is parsing a Module.

Ditto.

> Tools/Scripts/build-jsc:211
> +            if ($featureEnabled != $_->{default}) {

For string, we need to use ne instead of !=. This causes warnings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160921/c48bf290/attachment.html>