<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement parsing of Async Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=161409">bug 161409</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #289447 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement parsing of Async Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=161409#c41">Comment # 41</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement parsing of Async Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=161409">bug 161409</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289447&action=diff" name="attach_289447" title="Async Function Parsing v6 + Copy-edit the build-jsc help message changes">attachment 289447</a> <a href="attachment.cgi?id=289447&action=edit" title="Async Function Parsing v6 + Copy-edit the build-jsc help message changes">[details]</a></span>
Async Function Parsing v6 + Copy-edit the build-jsc help message changes
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289447&action=review">https://bugs.webkit.org/attachment.cgi?id=289447&action=review</a>
r=me, with nits.
<span class="quote">> Source/JavaScriptCore/ChangeLog:87
> + * runtime/CommonIdentifiers.h:</span >
Could you update this ChangeLog by using Tools/Scripts/webkit-patch upload --update-changelogs?
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:1560
> + // FIXME: `m_moduleScopeData.get() != nullptr` is not a valid method of determining if parser is parsing a Module.</span >
Could you open a bug for this and note the URL here?
And I think this can be easily fixed since we already have this information: JSParserCommentMode {Classic, Module}!
This flag is named like this since currently it is only used for controlling comment mode. When you use this information here, you need to rename this mode to something different one (maybe, JSParserScriptMode?).
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:1568
> + // FIXME: `m_moduleScopeData.get() != nullptr` is not a valid method of determining if parser is parsing a Module.</span >
Ditto.
<span class="quote">> Tools/Scripts/build-jsc:211
> + if ($featureEnabled != $_->{default}) {</span >
For string, we need to use ne instead of !=. This causes warnings.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>