[Webkit-unassigned] [Bug 162267] [GTK] Clean up DataObjectGtk handling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162267

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289342|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 289342
  --> https://bugs.webkit.org/attachment.cgi?id=289342
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=289342&action=review

> Source/WebCore/platform/gtk/PasteboardHelper.cpp:295
> +        TemporaryChange<DataObjectGtk*> change(settingClipboardDataObject, const_cast<DataObjectGtk*>(&dataObject));

Why is this function receiving a const DataObjectGtk*? Why were you unable to get rid of this const_cast?

> Source/WebKit2/Shared/gtk/PasteboardContent.cpp:36
> +PasteboardContent::PasteboardContent(const WebCore::DataObjectGtk& data)
> +    : dataObject(const_cast<WebCore::DataObjectGtk&>(data))

Again, why is the parameter const? What call site cannot be fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160920/e577f61e/attachment-0001.html>