<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Clean up DataObjectGtk handling"
href="https://bugs.webkit.org/show_bug.cgi?id=162267">bug 162267</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #289342 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Clean up DataObjectGtk handling"
href="https://bugs.webkit.org/show_bug.cgi?id=162267#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Clean up DataObjectGtk handling"
href="https://bugs.webkit.org/show_bug.cgi?id=162267">bug 162267</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289342&action=diff" name="attach_289342" title="Patch">attachment 289342</a> <a href="attachment.cgi?id=289342&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289342&action=review">https://bugs.webkit.org/attachment.cgi?id=289342&action=review</a>
<span class="quote">> Source/WebCore/platform/gtk/PasteboardHelper.cpp:295
> + TemporaryChange<DataObjectGtk*> change(settingClipboardDataObject, const_cast<DataObjectGtk*>(&dataObject));</span >
Why is this function receiving a const DataObjectGtk*? Why were you unable to get rid of this const_cast?
<span class="quote">> Source/WebKit2/Shared/gtk/PasteboardContent.cpp:36
> +PasteboardContent::PasteboardContent(const WebCore::DataObjectGtk& data)
> + : dataObject(const_cast<WebCore::DataObjectGtk&>(data))</span >
Again, why is the parameter const? What call site cannot be fixed?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>