[Webkit-unassigned] [Bug 161907] [GTK] Get rid of DataObjectGtk::forClipboard and cleanup pasteboard code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161907

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 288687 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=288687&action=review
> > 
> > > Source/WebCore/platform/gtk/PasteboardGtk.cpp:99
> > > -DataObjectGtk* Pasteboard::dataObject() const
> > > +const DataObjectGtk& Pasteboard::dataObject() const
> > >  {
> > > -    return m_dataObject.get();
> > > +    return *m_dataObject;
> > >  }
> > 
> > You should also change m_dataObject to be a (non-const) reference, since
> > it's always initialized in the constructor initializer lists and there are
> > also ASSERTs to ensure it's not null. Then you can get rid of the ASSERTS,
> > and don't have to dereference it throughout the file anymore.
> 
> Yes, I tried that, but it's not that easy because of the way DragData works,
> I plan to do another cleanup after the clipboard is moved to the UI process,
> to not delay more that patch.
> 

The cleanup
https://bugs.webkit.org/show_bug.cgi?id=162267

The next step is renaming DataObjectGtk to something like SelectionData.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160920/65dae2d6/attachment.html>