<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] Get rid of DataObjectGtk::forClipboard and cleanup pasteboard code"
href="https://bugs.webkit.org/show_bug.cgi?id=161907#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] Get rid of DataObjectGtk::forClipboard and cleanup pasteboard code"
href="https://bugs.webkit.org/show_bug.cgi?id=161907">bug 161907</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=161907#c3">comment #3</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=161907#c2">comment #2</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=288687&action=diff" name="attach_288687" title="Patch">attachment 288687</a> <a href="attachment.cgi?id=288687&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=288687&action=review">https://bugs.webkit.org/attachment.cgi?id=288687&action=review</a>
> >
> > > Source/WebCore/platform/gtk/PasteboardGtk.cpp:99
> > > -DataObjectGtk* Pasteboard::dataObject() const
> > > +const DataObjectGtk& Pasteboard::dataObject() const
> > > {
> > > - return m_dataObject.get();
> > > + return *m_dataObject;
> > > }
> >
> > You should also change m_dataObject to be a (non-const) reference, since
> > it's always initialized in the constructor initializer lists and there are
> > also ASSERTs to ensure it's not null. Then you can get rid of the ASSERTS,
> > and don't have to dereference it throughout the file anymore.
>
> Yes, I tried that, but it's not that easy because of the way DragData works,
> I plan to do another cleanup after the clipboard is moved to the UI process,
> to not delay more that patch.
> </span >
The cleanup
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Clean up DataObjectGtk handling"
href="show_bug.cgi?id=162267">https://bugs.webkit.org/show_bug.cgi?id=162267</a>
The next step is renaming DataObjectGtk to something like SelectionData.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>