[Webkit-unassigned] [Bug 161409] [JSC] Implement parsing of Async Functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161409

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289289|review?                     |review+
              Flags|                            |

--- Comment #34 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 289289
  --> https://bugs.webkit.org/attachment.cgi?id=289289
Async Function Parsing v5

View in context: https://bugs.webkit.org/attachment.cgi?id=289289&action=review

r=me with comments.

> Source/JavaScriptCore/parser/Parser.cpp:3174
> +            ExpressionErrorClassifier classifier(this);

Is this necessary? parseAssignmentExpression(context) has ExpressionErrorClassifier inside it.

> Source/JavaScriptCore/parser/Parser.cpp:3522
> +    // AwaitExpression desugared to YieldExpression

This comment is not necessary.

> Source/JavaScriptCore/parser/Parser.h:320
> +    }

What is the purpose of this `isModule()`?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160920/976a0098/attachment.html>