<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement parsing of Async Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=161409">bug 161409</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #289289 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement parsing of Async Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=161409#c34">Comment # 34</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] Implement parsing of Async Functions"
href="https://bugs.webkit.org/show_bug.cgi?id=161409">bug 161409</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=289289&action=diff" name="attach_289289" title="Async Function Parsing v5">attachment 289289</a> <a href="attachment.cgi?id=289289&action=edit" title="Async Function Parsing v5">[details]</a></span>
Async Function Parsing v5
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=289289&action=review">https://bugs.webkit.org/attachment.cgi?id=289289&action=review</a>
r=me with comments.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:3174
> + ExpressionErrorClassifier classifier(this);</span >
Is this necessary? parseAssignmentExpression(context) has ExpressionErrorClassifier inside it.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:3522
> + // AwaitExpression desugared to YieldExpression</span >
This comment is not necessary.
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:320
> + }</span >
What is the purpose of this `isModule()`?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>