[Webkit-unassigned] [Bug 160497] MemoryPressureHandler shouldn't know how to release WebCore memory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160497

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 285219 [details]
> WIP patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285219&action=review
> 
> This is quite nice :)

Thanks, I still need help with the XCode changes.

> > Source/WebKit/mac/WebView/WebView.mm:1127
> > +        notify_register_dispatch("com.apple.WebKit.fullGC", &dummy, dispatch_get_main_queue(), ^(int) {
> > +            GCController::singleton().garbageCollectNow();
> > +        });
> > +        notify_register_dispatch("com.apple.WebKit.deleteAllCode", &dummy, dispatch_get_main_queue(), ^(int) {
> > +            GCController::singleton().deleteAllCode();
> > +            GCController::singleton().garbageCollectNow();
> > +        });
> 
> This code is duplicated in both WebKit1 and WebKit2. If a process uses both,
> it will hook 2 separate callbacks to each notification name, effectively
> making the callbacks execute twice.

Is it really possible to use WebKit1 and WebKit2 from the same process? The WebKit2 code is in the web process initialization, so even if an application uses both, the UI process would install the WebKit1 callbacks and the web processes the WebKit2 ones. So, I'm not sure this is a problem. It would only be a problem if webkit1 can be used from a webkit2 injected bundle or something like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160919/e8843975/attachment-0001.html>