<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler shouldn't know how to release WebCore memory"
href="https://bugs.webkit.org/show_bug.cgi?id=160497#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - MemoryPressureHandler shouldn't know how to release WebCore memory"
href="https://bugs.webkit.org/show_bug.cgi?id=160497">bug 160497</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160497#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=285219&action=diff" name="attach_285219" title="WIP patch">attachment 285219</a> <a href="attachment.cgi?id=285219&action=edit" title="WIP patch">[details]</a></span>
> WIP patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=285219&action=review">https://bugs.webkit.org/attachment.cgi?id=285219&action=review</a>
>
> This is quite nice :)</span >
Thanks, I still need help with the XCode changes.
<span class="quote">> > Source/WebKit/mac/WebView/WebView.mm:1127
> > + notify_register_dispatch("com.apple.WebKit.fullGC", &dummy, dispatch_get_main_queue(), ^(int) {
> > + GCController::singleton().garbageCollectNow();
> > + });
> > + notify_register_dispatch("com.apple.WebKit.deleteAllCode", &dummy, dispatch_get_main_queue(), ^(int) {
> > + GCController::singleton().deleteAllCode();
> > + GCController::singleton().garbageCollectNow();
> > + });
>
> This code is duplicated in both WebKit1 and WebKit2. If a process uses both,
> it will hook 2 separate callbacks to each notification name, effectively
> making the callbacks execute twice.</span >
Is it really possible to use WebKit1 and WebKit2 from the same process? The WebKit2 code is in the web process initialization, so even if an application uses both, the UI process would install the WebKit1 callbacks and the web processes the WebKit2 ones. So, I'm not sure this is a problem. It would only be a problem if webkit1 can be used from a webkit2 injected bundle or something like that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>