[Webkit-unassigned] [Bug 138171] FormData should not use Document, Page, Chrome and ChromeClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138171

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #240599|review?                     |
              Flags|                            |

--- Comment #10 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 240599
  --> https://bugs.webkit.org/attachment.cgi?id=240599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240599&action=review

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.

> Source/WebCore/loader/FrameLoader.cpp:360
> +    if (Page* page = m_frame.document()->page())

Why do you not need to null-check document and page, you're sure this is safe? My defeatist, non-ideal strategy is to null-check these always, as I've given up on understanding when they can and cannot be null....

> Source/WebCore/loader/FrameLoader.cpp:361
> +        data.generateFiles([page](const String& path) -> String { return page->chrome().client().generateReplacementFile(path); });

Why do you need to specify the return type of the lambda? Is it not inferred?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160917/93df2489/attachment.html>