<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - FormData should not use Document, Page, Chrome and ChromeClient"
href="https://bugs.webkit.org/show_bug.cgi?id=138171">bug 138171</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #240599 Flags</td>
<td>review?
</td>
<td>
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - FormData should not use Document, Page, Chrome and ChromeClient"
href="https://bugs.webkit.org/show_bug.cgi?id=138171#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - FormData should not use Document, Page, Chrome and ChromeClient"
href="https://bugs.webkit.org/show_bug.cgi?id=138171">bug 138171</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=240599&action=diff" name="attach_240599" title="Patch">attachment 240599</a> <a href="attachment.cgi?id=240599&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=240599&action=review">https://bugs.webkit.org/attachment.cgi?id=240599&action=review</a>
Hi,
Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.
To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.
<span class="quote">> Source/WebCore/loader/FrameLoader.cpp:360
> + if (Page* page = m_frame.document()->page())</span >
Why do you not need to null-check document and page, you're sure this is safe? My defeatist, non-ideal strategy is to null-check these always, as I've given up on understanding when they can and cannot be null....
<span class="quote">> Source/WebCore/loader/FrameLoader.cpp:361
> + data.generateFiles([page](const String& path) -> String { return page->chrome().client().generateReplacementFile(path); });</span >
Why do you need to specify the return type of the lambda? Is it not inferred?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>