[Webkit-unassigned] [Bug 162030] makeRGBAFromNSColor should use the NSColor's colorSpace instead of hardcoding NSDeviceRGBColorSpace
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 15 13:05:58 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=162030
Simon Fraser (smfr) <simon.fraser at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #288986|review? |review-
Flags| |
--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 288986
--> https://bugs.webkit.org/attachment.cgi?id=288986
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=288986&action=review
> Source/WebCore/platform/graphics/mac/ColorMac.mm:60
> - NSColor *rgbColor = [c colorUsingColorSpaceName:NSDeviceRGBColorSpace];
> + NSColor *rgbColor = [c colorUsingColorSpaceName:c.colorSpaceName];
This is wrong. This call is explicitly trying to convert from an arbitrary colorspace (e.g. CalibratedGray) to RGB. So it should use CalibratedRGB, not DeviceRGB.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160915/37732df5/attachment.html>
More information about the webkit-unassigned
mailing list