<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - makeRGBAFromNSColor should use the NSColor's colorSpace instead of hardcoding NSDeviceRGBColorSpace"
href="https://bugs.webkit.org/show_bug.cgi?id=162030">bug 162030</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #288986 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - makeRGBAFromNSColor should use the NSColor's colorSpace instead of hardcoding NSDeviceRGBColorSpace"
href="https://bugs.webkit.org/show_bug.cgi?id=162030#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - makeRGBAFromNSColor should use the NSColor's colorSpace instead of hardcoding NSDeviceRGBColorSpace"
href="https://bugs.webkit.org/show_bug.cgi?id=162030">bug 162030</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=288986&action=diff" name="attach_288986" title="Patch">attachment 288986</a> <a href="attachment.cgi?id=288986&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=288986&action=review">https://bugs.webkit.org/attachment.cgi?id=288986&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/mac/ColorMac.mm:60
> - NSColor *rgbColor = [c colorUsingColorSpaceName:NSDeviceRGBColorSpace];
> + NSColor *rgbColor = [c colorUsingColorSpaceName:c.colorSpaceName];</span >
This is wrong. This call is explicitly trying to convert from an arbitrary colorspace (e.g. CalibratedGray) to RGB. So it should use CalibratedRGB, not DeviceRGB.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>