[Webkit-unassigned] [Bug 161904] [GTK] Drop redundant wl_display_flush_clients() call

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 05:05:38 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=161904

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 288684
  --> https://bugs.webkit.org/attachment.cgi?id=288684
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288684&action=review

> Source/WebKit2/ChangeLog:10
> +        The Wayland GSource::prepare() function already calls
> +        wl_display_flush_clients() at every mainloop iteration, so there's no
> +        need to further call it on Surface::commit().

That's not equivalent, prepare is called before dispatch, and commit happens on dispatch. I'm not saying we need to flush on commit, because I don't know, I copied that from previous patches, but this explanation is not clear to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160913/fc9caccf/attachment.html>


More information about the webkit-unassigned mailing list