<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Drop redundant wl_display_flush_clients() call"
href="https://bugs.webkit.org/show_bug.cgi?id=161904#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Drop redundant wl_display_flush_clients() call"
href="https://bugs.webkit.org/show_bug.cgi?id=161904">bug 161904</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=288684&action=diff" name="attach_288684" title="Patch">attachment 288684</a> <a href="attachment.cgi?id=288684&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=288684&action=review">https://bugs.webkit.org/attachment.cgi?id=288684&action=review</a>
<span class="quote">> Source/WebKit2/ChangeLog:10
> + The Wayland GSource::prepare() function already calls
> + wl_display_flush_clients() at every mainloop iteration, so there's no
> + need to further call it on Surface::commit().</span >
That's not equivalent, prepare is called before dispatch, and commit happens on dispatch. I'm not saying we need to flush on commit, because I don't know, I copied that from previous patches, but this explanation is not clear to me.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>