[Webkit-unassigned] [Bug 161493] [FreeType] Incorrect application of glyph positioning in the Y direction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161493

--- Comment #18 from Myles C. Maxfield <mmaxfield at apple.com> ---
(In reply to comment #17)
> (In reply to comment #11)
> > GlyphBuffer is only used for painting. As such, we can save space if,
> > instead of storing separate advances / origins in it, we collapse these into
> > "painting advances" which are the offset from each glyph's paint position to
> > the next.
> > 
> > I considered renaming GlyphBuffer to something like PaintingGlyphBuffer but
> > ultimately decided it wasn't worth the effort.
> > 
> > Ultimately, we should remove the m_offsets member from GlyphBuffer in the
> > Windows port. I plan on doing this at some point in the future. Rather than
> > increasing the usage of this variable, I would suggest computing each
> > glyph's paint position inside HarfBuzzShaper (thereby taking into account
> > the offsets) and storing that in GlyphBuffer.
> 
> I'm doing this at https://bugs.webkit.org/show_bug.cgi?id=161814

Whoops, looks like it's used in FontCGWin.cpp... not sure how I missed that...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160910/bafdf24d/attachment.html>