[Webkit-unassigned] [Bug 161493] [FreeType] Incorrect application of glyph positioning in the Y direction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=161493

--- Comment #16 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 287860
  --> https://bugs.webkit.org/attachment.cgi?id=287860
Proof of concept patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287860&action=review

>>> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:580
>>> +                glyphBuffer->add(glyphs[i], currentRun->fontData(), createGlyphBufferAdvance(glyphAdvanceX, glyphAdvanceY), currentCharacterIndex, &offset);
>> 
>> It appears that FontCascade::drawGlyphBuffer() doesn't actually move any glyphs according to the offsets. How does this work?
> 
> There is a different add() function which takes a GlyphBufferAdvance, which should be 2-dimensional.

Hopefully, if you migrate to this other add() function, you can remove the entire add() function which takes the float width.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160909/7032519b/attachment.html>