<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [FreeType] Incorrect application of glyph positioning in the Y direction"
href="https://bugs.webkit.org/show_bug.cgi?id=161493#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [FreeType] Incorrect application of glyph positioning in the Y direction"
href="https://bugs.webkit.org/show_bug.cgi?id=161493">bug 161493</a>
from <span class="vcard"><a class="email" href="mailto:mmaxfield@apple.com" title="Myles C. Maxfield <mmaxfield@apple.com>"> <span class="fn">Myles C. Maxfield</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=287860&action=diff" name="attach_287860" title="Proof of concept patch">attachment 287860</a> <a href="attachment.cgi?id=287860&action=edit" title="Proof of concept patch">[details]</a></span>
Proof of concept patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=287860&action=review">https://bugs.webkit.org/attachment.cgi?id=287860&action=review</a>
<span class="quote">>>> Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp:580
>>> + glyphBuffer->add(glyphs[i], currentRun->fontData(), createGlyphBufferAdvance(glyphAdvanceX, glyphAdvanceY), currentCharacterIndex, &offset);
>>
>> It appears that FontCascade::drawGlyphBuffer() doesn't actually move any glyphs according to the offsets. How does this work?
>
> There is a different add() function which takes a GlyphBufferAdvance, which should be 2-dimensional.</span >
Hopefully, if you migrate to this other add() function, you can remove the entire add() function which takes the float width.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>