[Webkit-unassigned] [Bug 161433] [CMake] CMake does not support the dep file of preprocess-idls.pl --supplementalMakefileDeps

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 9 05:20:59 PDT 2016


--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to comment #2)
> I've finished a experimental prototyping.
> > https://github.com/fujii/webkit/pull/1

You have to upload the patch here, with the r? flag set so a reviewer can take a look into it.

The patch should also contain changelogs (we have a tool to generate them).

Check: https://webkit.org/contributing-code/

Very summarized the process for git users is the following:

1. Commit to a local git branch your patch.
2. Generate a changelog for it as follows:
$ Tools/Scripts/prepare-ChangeLog -b $bugnumer -g $sha1hashofthecommit
3. Edit the changelogs and commit them amending the previous commit
4. Upload the patch here using this:
$ Tools/Scripts/webkit-patch upload -g $sha1hashofthenewammendedcommit --suggest-reviewers --request-commit

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160909/c3ad49dd/attachment.html>

More information about the webkit-unassigned mailing list