<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] CMake does not support the dep file of preprocess-idls.pl --supplementalMakefileDeps"
href="https://bugs.webkit.org/show_bug.cgi?id=161433#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] CMake does not support the dep file of preprocess-idls.pl --supplementalMakefileDeps"
href="https://bugs.webkit.org/show_bug.cgi?id=161433">bug 161433</a>
from <span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=161433#c2">comment #2</a>)
<span class="quote">> I've finished a experimental prototyping.
>
> > <a href="https://github.com/fujii/webkit/pull/1">https://github.com/fujii/webkit/pull/1</a>
> </span >
You have to upload the patch here, with the r? flag set so a reviewer can take a look into it.
The patch should also contain changelogs (we have a tool to generate them).
Check: <a href="https://webkit.org/contributing-code/">https://webkit.org/contributing-code/</a>
Very summarized the process for git users is the following:
1. Commit to a local git branch your patch.
2. Generate a changelog for it as follows:
$ Tools/Scripts/prepare-ChangeLog -b $bugnumer -g $sha1hashofthecommit
3. Edit the changelogs and commit them amending the previous commit
4. Upload the patch here using this:
$ Tools/Scripts/webkit-patch upload -g $sha1hashofthenewammendedcommit --suggest-reviewers --request-commit</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>