[Webkit-unassigned] [Bug 159631] [GTK] Add webkit_context_menu_item_new_from_gaction

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 6 15:06:04 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159631

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 288043
  --> https://bugs.webkit.org/attachment.cgi?id=288043
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288043&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuItem.cpp:216
> +    g_action_activate(actionData->action, actionData->parameter);
> +    actionData->parameter = nullptr;

If you use a GRefPtr for ActionData::parameter, then you would write here:

g_action_activate(actionData->action, actionData->parameter.leakRef());

And you would not need to set actionData->parameter = nullptr (leakRef will take care of that).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160906/5cb04ea2/attachment-0001.html>


More information about the webkit-unassigned mailing list