<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add webkit_context_menu_item_new_from_gaction"
href="https://bugs.webkit.org/show_bug.cgi?id=159631#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Add webkit_context_menu_item_new_from_gaction"
href="https://bugs.webkit.org/show_bug.cgi?id=159631">bug 159631</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=288043&action=diff" name="attach_288043" title="Patch">attachment 288043</a> <a href="attachment.cgi?id=288043&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=288043&action=review">https://bugs.webkit.org/attachment.cgi?id=288043&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuItem.cpp:216
> + g_action_activate(actionData->action, actionData->parameter);
> + actionData->parameter = nullptr;</span >
If you use a GRefPtr for ActionData::parameter, then you would write here:
g_action_activate(actionData->action, actionData->parameter.leakRef());
And you would not need to set actionData->parameter = nullptr (leakRef will take care of that).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>