[Webkit-unassigned] [Bug 161474] [CMake] Decouple generating bindings of WebCore and WebCoreTestSupport

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 1 17:27:22 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=161474

--- Comment #5 from Fujii Hironori <Hironori.Fujii at sony.com> ---
There are three problems:

1) This unnecessary dependency causes unnecessary recompilation

Updating supplementalDependencyFile triggers unnecessarily
regenerating bindings of WebCoreTestSupport.  This is actually a tiny
problem because WebCoreTestSupport doesn't have many IDL files.

2) VisualStudio projects generated by CMake triggers preprocess-idls.pl twice

Both WebCoreDerivedSources and WebCoreTestSupport projects trigger
preprocess-idls.pl because they depend on it.
This seems to cause following problems:

  Bug 155872 – [Win] CMake seems to build all generated files every time
  Bug 154938 – Generated sources triggers when not required

Unfortunately, This this patch solve this problem because both
WebCoreDerivedSources and WebCoreTestSupport projects still trigger
make-settings.pl. But, I think this is the right direction to go.

3) Unnecessarily complicated 

This change can simplify the build rule.  I have a plan to generate
bindings outside of CMake. This change can help so much.

  Bug 161433 – [CMake] CMake does not support the dep file of preprocess-idls.pl --supplementalMakefileDeps

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160902/ed540254/attachment-0001.html>


More information about the webkit-unassigned mailing list