<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Decouple generating bindings of WebCore and WebCoreTestSupport"
href="https://bugs.webkit.org/show_bug.cgi?id=161474#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] Decouple generating bindings of WebCore and WebCoreTestSupport"
href="https://bugs.webkit.org/show_bug.cgi?id=161474">bug 161474</a>
from <span class="vcard"><a class="email" href="mailto:Hironori.Fujii@sony.com" title="Fujii Hironori <Hironori.Fujii@sony.com>"> <span class="fn">Fujii Hironori</span></a>
</span></b>
<pre>There are three problems:
1) This unnecessary dependency causes unnecessary recompilation
Updating supplementalDependencyFile triggers unnecessarily
regenerating bindings of WebCoreTestSupport. This is actually a tiny
problem because WebCoreTestSupport doesn't have many IDL files.
2) VisualStudio projects generated by CMake triggers preprocess-idls.pl twice
Both WebCoreDerivedSources and WebCoreTestSupport projects trigger
preprocess-idls.pl because they depend on it.
This seems to cause following problems:
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - [Win] CMake seems to build all generated files every time"
href="show_bug.cgi?id=155872">Bug 155872</a> – [Win] CMake seems to build all generated files every time
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Generated sources triggers when not required"
href="show_bug.cgi?id=154938">Bug 154938</a> – Generated sources triggers when not required
Unfortunately, This this patch solve this problem because both
WebCoreDerivedSources and WebCoreTestSupport projects still trigger
make-settings.pl. But, I think this is the right direction to go.
3) Unnecessarily complicated
This change can simplify the build rule. I have a plan to generate
bindings outside of CMake. This change can help so much.
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [CMake] CMake does not support the dep file of preprocess-idls.pl --supplementalMakefileDeps"
href="show_bug.cgi?id=161433">Bug 161433</a> – [CMake] CMake does not support the dep file of preprocess-idls.pl --supplementalMakefileDeps</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>