[Webkit-unassigned] [Bug 137425] Plugin process crashes in NPN_InvokeDefault

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137425

--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #13)
> (In reply to comment #12)
> > (In reply to comment #11)
> > > Unfortunately it broke macOS tests, which will need to be investigated:
> > 
> > There's nothing to investigate, as I said the test needs to be added to
> > xcode, I knew it was not going to work.
> 
> I’d like to help or get someone to help you. I don’t understand, though.

Thanks.

> I believe you are pointing out that BrowserFunctionsInvalidArguments.cpp
> needs to be added to an Xcode project, and someone who develops on a Mac
> should help you add that to your patch.

Right.

> But how does this cause the browser-funcs-invalid-args.html and
> npruntime-calls-with-null-npp.html tests to fail?

browser-funcs-invalid-args.html is added in this patch and requires BrowserFunctionsInvalidArguments.cpp to work. I didn't realize npruntime-calls-with-null-npp.html was also failing, Michael is right and I need to investigate that one. But in any case I need BrowserFunctionsInvalidArguments.cpp to be built on mac.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161029/be06c03a/attachment.html>