<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Plugin process crashes in NPN_InvokeDefault"
href="https://bugs.webkit.org/show_bug.cgi?id=137425#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Plugin process crashes in NPN_InvokeDefault"
href="https://bugs.webkit.org/show_bug.cgi?id=137425">bug 137425</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=137425#c13">comment #13</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=137425#c12">comment #12</a>)
> > (In reply to <a href="show_bug.cgi?id=137425#c11">comment #11</a>)
> > > Unfortunately it broke macOS tests, which will need to be investigated:
> >
> > There's nothing to investigate, as I said the test needs to be added to
> > xcode, I knew it was not going to work.
>
> I’d like to help or get someone to help you. I don’t understand, though.</span >
Thanks.
<span class="quote">> I believe you are pointing out that BrowserFunctionsInvalidArguments.cpp
> needs to be added to an Xcode project, and someone who develops on a Mac
> should help you add that to your patch.</span >
Right.
<span class="quote">> But how does this cause the browser-funcs-invalid-args.html and
> npruntime-calls-with-null-npp.html tests to fail?</span >
browser-funcs-invalid-args.html is added in this patch and requires BrowserFunctionsInvalidArguments.cpp to work. I didn't realize npruntime-calls-with-null-npp.html was also failing, Michael is right and I need to investigate that one. But in any case I need BrowserFunctionsInvalidArguments.cpp to be built on mac.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>