[Webkit-unassigned] [Bug 164001] Add support for wide gamut for ShareableBitmap for image popovers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164001

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #293069|review?                     |review+
              Flags|                            |

--- Comment #15 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 293069
  --> https://bugs.webkit.org/attachment.cgi?id=293069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293069&action=review

> Source/WebCore/ChangeLog:8
> +        Added extendedColorSpace creator.

This doesn't match the actual function name. Would be better to say "Add a function to return a CGColorSpaceRef for extended sRGB".

> Source/WebCore/ChangeLog:10
> +        This is currently untestable, due to simulator limitations, so no tests added.

What about Mac, since this is shared code?

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:103
> +    // If there is no support on device, fall back to sRGB.

"on device" is confusing in code that's shared with Mac.

> Source/WebKit2/ChangeLog:12
> +        This also adds using wide gamut images for image popovers in mobileSafari.

"This also adds using wide gamut images for image popovers in mobileSafari." -> "This makes it possible to show wide gamut images in image popovers on iOS".

> Source/WebKit2/ChangeLog:13
> +        This is currently untestable, due to simulator limitations, so no tests added.

But this code also compiles on Mac, so you need an excuse to not test on Mac too :)

> Source/WebKit2/Shared/ShareableBitmap.h:76
> +        uint64_t m_bytesPerPixel;

Still uint64_t.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161027/f3023414/attachment.html>