<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001">bug 164001</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #293069 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001">bug 164001</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=293069&action=diff" name="attach_293069" title="Patch">attachment 293069</a> <a href="attachment.cgi?id=293069&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=293069&action=review">https://bugs.webkit.org/attachment.cgi?id=293069&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:8
> + Added extendedColorSpace creator.</span >
This doesn't match the actual function name. Would be better to say "Add a function to return a CGColorSpaceRef for extended sRGB".
<span class="quote">> Source/WebCore/ChangeLog:10
> + This is currently untestable, due to simulator limitations, so no tests added.</span >
What about Mac, since this is shared code?
<span class="quote">> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:103
> + // If there is no support on device, fall back to sRGB.</span >
"on device" is confusing in code that's shared with Mac.
<span class="quote">> Source/WebKit2/ChangeLog:12
> + This also adds using wide gamut images for image popovers in mobileSafari.</span >
"This also adds using wide gamut images for image popovers in mobileSafari." -> "This makes it possible to show wide gamut images in image popovers on iOS".
<span class="quote">> Source/WebKit2/ChangeLog:13
> + This is currently untestable, due to simulator limitations, so no tests added.</span >
But this code also compiles on Mac, so you need an excuse to not test on Mac too :)
<span class="quote">> Source/WebKit2/Shared/ShareableBitmap.h:76
> + uint64_t m_bytesPerPixel;</span >
Still uint64_t.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>