[Webkit-unassigned] [Bug 136989] [GTK] JSC bindings not introspectable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136989

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|WebKit2 Gtk+                |[GTK] JSC bindings not
                   |JavaScriptCore bindings     |introspectable
                   |doesn't work properly       |

--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Thanks for your patch Jack!

I don't see any reason not to add webkit_javascript_result_to_string, but I think it belongs in a separate bug since it doesn't really solve the problem here. Georges wants to be able to use JSC from Python, that requires introspection support, and that in turn depends on bug #164061. So I think you should file a new bug and attach your patch there. Please also see https://webkit.org/contributing-code/ for tips on contributing patches (set the r? and cq? Bugzilla flags, give the patch a ChangeLog entry).

As for the patch itself, it looks sane to me, just one style nit in the header file:

WEBKIT_API gchar*

Since the header file follows GNOME coding style, it should be gchar * with a space before the *, unlike the WebKit coding style used in the rest of the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161027/df54eb7b/attachment-0001.html>