<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] JSC bindings not introspectable"
href="https://bugs.webkit.org/show_bug.cgi?id=136989">bug 136989</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>WebKit2 Gtk+ JavaScriptCore bindings doesn't work properly
</td>
<td>[GTK] JSC bindings not introspectable
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] JSC bindings not introspectable"
href="https://bugs.webkit.org/show_bug.cgi?id=136989#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] JSC bindings not introspectable"
href="https://bugs.webkit.org/show_bug.cgi?id=136989">bug 136989</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Thanks for your patch Jack!
I don't see any reason not to add webkit_javascript_result_to_string, but I think it belongs in a separate bug since it doesn't really solve the problem here. Georges wants to be able to use JSC from Python, that requires introspection support, and that in turn depends on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Initial implementation of JavaScriptCore glib bindings"
href="show_bug.cgi?id=164061">bug #164061</a>. So I think you should file a new bug and attach your patch there. Please also see <a href="https://webkit.org/contributing-code/">https://webkit.org/contributing-code/</a> for tips on contributing patches (set the r? and cq? Bugzilla flags, give the patch a ChangeLog entry).
As for the patch itself, it looks sane to me, just one style nit in the header file:
WEBKIT_API gchar*
Since the header file follows GNOME coding style, it should be gchar * with a space before the *, unlike the WebKit coding style used in the rest of the code.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>