[Webkit-unassigned] [Bug 164001] Add support for wide gamut for ShareableBitmap for image popovers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164001

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #292873|review?                     |review-
              Flags|                            |

--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 292873
  --> https://bugs.webkit.org/attachment.cgi?id=292873
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292873&action=review

> Source/WebKit2/Shared/ShareableBitmap.cpp:37
> +static uint calculateBytesPerPixel(ShareableBitmap::Flags flags)

uint -> unsigned.

> Source/WebKit2/Shared/ShareableBitmap.cpp:40
> +        return 8;

You should add a comment here saying which format we use for SupportsExtendedColor, so why 8 is the right number.

> Source/WebKit2/Shared/ShareableBitmap.cpp:78
> +    uint bytesPerPixel = calculateBytesPerPixel(flags);

unsigned. Or just remove this variable.

> Source/WebKit2/Shared/ShareableBitmap.cpp:101
> +    return adoptRef(new ShareableBitmap(size, flags, bytesPerPixel, sharedMemory));

I'm a bit confused about why bytesPerPixel needs to be passed in. Can't ShareableBitmap compute it from flags?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161026/366f0b31/attachment.html>