<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001">bug 164001</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #292873 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001">bug 164001</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=292873&action=diff" name="attach_292873" title="Patch">attachment 292873</a> <a href="attachment.cgi?id=292873&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=292873&action=review">https://bugs.webkit.org/attachment.cgi?id=292873&action=review</a>
<span class="quote">> Source/WebKit2/Shared/ShareableBitmap.cpp:37
> +static uint calculateBytesPerPixel(ShareableBitmap::Flags flags)</span >
uint -> unsigned.
<span class="quote">> Source/WebKit2/Shared/ShareableBitmap.cpp:40
> + return 8;</span >
You should add a comment here saying which format we use for SupportsExtendedColor, so why 8 is the right number.
<span class="quote">> Source/WebKit2/Shared/ShareableBitmap.cpp:78
> + uint bytesPerPixel = calculateBytesPerPixel(flags);</span >
unsigned. Or just remove this variable.
<span class="quote">> Source/WebKit2/Shared/ShareableBitmap.cpp:101
> + return adoptRef(new ShareableBitmap(size, flags, bytesPerPixel, sharedMemory));</span >
I'm a bit confused about why bytesPerPixel needs to be passed in. Can't ShareableBitmap compute it from flags?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>