[Webkit-unassigned] [Bug 164001] Add support for wide gamut for ShareableBitmap for image popovers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164001

--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 292870
  --> https://bugs.webkit.org/attachment.cgi?id=292870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292870&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:103
> +    // if there is no support on device, fall back to sRGB

Capital I, end with a period! (https://webkit.org/code-style-guidelines/#comments-sentences)

> Source/WebKit2/Shared/ShareableBitmap.cpp:54
> +    encoder << m_bytesPerPixel;

Why do we encode it if it's computable given m_flags, which we already encode?

> Source/WebKit2/Shared/ShareableBitmap.h:130
> +    // FIXME: make sure this is ok, this seems to be windows thing, maybe??

Get rid of the comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161026/aa86a5ab/attachment.html>