<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add support for wide gamut for ShareableBitmap for image popovers"
href="https://bugs.webkit.org/show_bug.cgi?id=164001">bug 164001</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=292870&action=diff" name="attach_292870" title="Patch">attachment 292870</a> <a href="attachment.cgi?id=292870&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=292870&action=review">https://bugs.webkit.org/attachment.cgi?id=292870&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:103
> + // if there is no support on device, fall back to sRGB</span >
Capital I, end with a period! (<a href="https://webkit.org/code-style-guidelines/#comments-sentences">https://webkit.org/code-style-guidelines/#comments-sentences</a>)
<span class="quote">> Source/WebKit2/Shared/ShareableBitmap.cpp:54
> + encoder << m_bytesPerPixel;</span >
Why do we encode it if it's computable given m_flags, which we already encode?
<span class="quote">> Source/WebKit2/Shared/ShareableBitmap.h:130
> + // FIXME: make sure this is ok, this seems to be windows thing, maybe??</span >
Get rid of the comment.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>